ISSDK-1876: Skip x-createOnly defaults in Go NewXxx/NewXxxWithDefaults constructors#177
Open
sagadira wants to merge 1 commit into
Open
ISSDK-1876: Skip x-createOnly defaults in Go NewXxx/NewXxxWithDefaults constructors#177sagadira wants to merge 1 commit into
sagadira wants to merge 1 commit into
Conversation
…ts Go constructors
Properties marked x-createOnly must not be injected into the struct by
the generated constructors -- the Intersight API rejects them in POST if
they arrive with a stale default value (e.g. ServerFamily='All' on
server.Profile / server.ProfileTemplate).
Add {{^vendorExtensions.x-createOnly}} guards around the default-value
assignment blocks in both New{{classname}} and New{{classname}}WithDefaults
in model_simple.mustache, mirroring the existing {{^isReadOnly}} pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Go SDK sending
x-createOnlyproperty defaults on resource creation, which the Intersight API rejects (e.g.server_family).Change
go/model_simple.mustache(+4): the generatedNewXxx()/NewXxxWithDefaults()constructors no longer assign default values for properties markedx-createOnly. Previously ax-createOnlyproperty with a default (e.g.ServerFamily = "Unspecified") was initialised in the constructor and then sent in the POST body, causing400 "Cannot modify the read-only property ...".This is the Go-SDK analog of the Terraform
createOnly -> Computedfix.Scope
x-createOnlyis an Intersight extension) — not an upstream candidate.Ticket: ISSDK-1876